Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hydration URL check #9890

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Aug 19, 2024

tl;dr; this was only needed in React 17 and can be dropped now that Remix v2 requires React 18. This will get rid of some false-positive scenarios we have today.

See changeset and #1757 (comment) for details.

Closes #8872, #7529

Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: a45848b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/serve Patch
create-remix Patch
remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikkelwf
Copy link

We´re experiencing this bug in production right now.
A fast merge and subsequent release would be appreciated.. :)

@brophdawg11 brophdawg11 merged commit 30a72fc into dev Aug 20, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/remove-hydration-url-check branch August 20, 2024 16:20
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants